features: define a custom folder for the summaries and transcriptions, pretty formatting for the markdown export, use openai compatible endpoints, CLI to build and run the project locally, ...#16
Open
nilleb wants to merge 69 commits into
Conversation
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
the sampling rate differs from the previously set one
Replace string concatenation with multiline literals in logger calls to fix compilation errors and comply with SwiftLint line length rules. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This comprehensive refactoring addresses all critical swiftlint violations and significantly improves code quality and maintainability: ## Violations Fixed ### Closure Parameter Position (5 files) ✅ - Fixed closure parameters to be on same line as opening brace - Updated in DropdownWindowManager, RecapsWindowManager, MicrophoneCapture+AudioEngine, LLMService ### Function Body Length (6 files) ✅ - ProcessTap.swift: Extracted helper methods (createTapDescription, createProcessTap, createAggregateDevice) - AudioRecordingCoordinator.swift: Extracted startSystemAudioRecording, startMicrophoneRecording, getTapStreamDescription - GlobalShortcutManager.swift: Replaced switch with dictionary lookup - SummaryView.swift: Extracted stateHeader, actionSection, stateWarningMessage, button computed properties - AlertToast.swift: Extracted view mode methods and handleTapGesture ### Cyclomatic Complexity (3 occurrences) ✅ - GlobalShortcutManager.getKeyString: Reduced from 57 to 1 using dictionary - GlobalShortcutSettingsView.getKeyString: Replaced with dictionary lookup - GlobalShortcutSettingsView.getKeyCodeFromKeyEquivalent: Simplified with dictionary + small switch ### Type Body Length (5 files) ✅ - UserPreferencesRepository: 345→176 lines (extracted performUpdate helper, consolidated update methods) - ProcessingCoordinator: Extracted processSummarizationIfEnabled, saveTranscriptionResults - GeneralSettingsViewModel: Extracted validation and model update methods - GeneralSettingsView: Reduced by extracting preview mocks - SummaryView: Extracted helper methods and computed properties ### File Length (3 files) ✅ - AlertToast.swift: 775→425 lines (45% reduction) - Created AnimatedCheckmark.swift - Created AlertToast+Modifiers.swift - Created AlertToastTypes.swift - Created View+Toast.swift - GeneralSettingsView.swift: 444→332 lines - Created GeneralSettingsView+Preview.swift - GeneralSettingsViewModelSpec.swift: Minor test file cleanup ## Files Created - Recap/Frameworks/Toast/AnimatedCheckmark.swift - Recap/Frameworks/Toast/AlertToast+Modifiers.swift - Recap/Frameworks/Toast/AlertToastTypes.swift - Recap/Frameworks/Toast/View+Toast.swift - Recap/UseCases/Settings/Components/TabViews/GeneralSettingsView+Preview.swift ## Build Status ✅ All files compile successfully ✅ No swiftlint errors remaining⚠️ 8 minor warnings remain (file/type length just above thresholds) ## Key Improvements - Better code organization with logical method extraction - Reduced complexity using dictionaries instead of large switch statements - Improved reusability with extracted helpers (e.g., performUpdate()) - Better separation of concerns with extracted preview mocks - Maintained functionality while improving maintainability 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
feat: drag and drop and test the configured LLM
nilleb
changed the title
|
I'd love to see this merged!! specially retrying the transcription / summarization. It also would be very cool to be able to copy the transcriptions/summaries in a click! |
|
Same I love that so much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I do not expect you to merge this, Rawa, but I wanted to show you what I did - and let you pick the features you like.
Just name the features you'd like to have merged and I'll try to do that.
The features present in this branch
Notable fixes:
All this has been done with Claude/Codex/Cursor (with little supervision of my own)
All the best
Type of Change
Testing
Checklist
Screenshots (if applicable)
Additional Notes