Skip to content

[bugfix] Fix #400 error when adding a member to admin list#13

Closed
iTaysonLab wants to merge 1 commit intomainfrom
bugfix/addAdmin
Closed

[bugfix] Fix #400 error when adding a member to admin list#13
iTaysonLab wants to merge 1 commit intomainfrom
bugfix/addAdmin

Conversation

@iTaysonLab
Copy link
Copy Markdown
Contributor

@iTaysonLab iTaysonLab commented Aug 27, 2021

No description provided.

@iTaysonLab
"Add administrator" now edits rights if a member
fd9dbad 
Signed-off-by: iTaysonLab <9827543+iTaysonLab@users.noreply.github.com>
@iTaysonLab iTaysonLab added the bugfix PRs that provide bug fixes label Aug 28, 2021
vkryl
vkryl reviewed Aug 28, 2021
View reviewed changes
app/src/main/java/org/thunderdog/challegram/ui/ProfileController.java
return false;
}
} else if (currentPickMode == MODE_MEMBER_ADMIN) {
if (isAlreadyMember(user.id) && !tdlib.isSelfUserId(user.id) && membersAdapter != null && membersAdapter.getChatMember(user.id) != null) {
Copy link
Copy Markdown
Member

@vkryl vkryl Aug 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

membersAdapter != null && membersAdapter.getChatMember(user.id) != null means that any user that's not loaded on the list will not be covered by this fix.
vkryl
vkryl reviewed Aug 28, 2021
View reviewed changes
app/src/main/java/org/thunderdog/challegram/ui/ProfileController.java
}
} else if (currentPickMode == MODE_MEMBER_ADMIN) {
if (isAlreadyMember(user.id) && !tdlib.isSelfUserId(user.id) && membersAdapter != null && membersAdapter.getChatMember(user.id) != null) {
tdlib.client().send(new TdApi.GetChatMember(chat.id, new TdApi.MessageSenderUser(user.id)), r -> {
Copy link
Copy Markdown
Member

@vkryl vkryl Aug 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that there's a preceding membersAdapter.getChatMember(user.id) != null check, requesting fresh status from server here isn't a requirement, client could use membersAdapter.getChatMember(user.id).
@vkryl
Copy link
Copy Markdown
Member

vkryl commented Aug 28, 2021

This is not a proper fix:

  1. It covers only members that are currently visible on ProfileController. It doesn't cover any members that are not loaded into UI because of membersAdapter.getMember(user.id) != null check.
  2. It disables all specific cases covered by addChannelMember method.

Fixed in 059fba7 by supporting basic groups in addChannelMember, renaming it to just addMember and giving an ability to select amount of messages to forward when adding administrator when it's not a part of current chat.
@vkryl vkryl closed this Aug 28, 2021
@vkryl vkryl deleted the bugfix/addAdmin branch August 28, 2021 21:53
japananimetime added a commit to japananimetime/Telegram-X that referenced this pull request Dec 29, 2025
@japananimetime @claude
Forum topics: fix mute badge, read receipts, notifications, and polis…
57bc7df 
…h share UI

- Fix unread badge not respecting mute state (issue TGX-Android#2)
  Added forumTopicNeedsMuteIcon() to properly check topic/chat mute hierarchy

- Fix forum badge not updating after reading all topics (issue TGX-Android#4)
  Call updateForumTopicUnreadCount() after fetching fresh topic data

- Fix read receipts not showing in topic messages (issue TGX-Android#9)
  Call manager.updateChatReadOutbox() in onForumTopicUpdated

- Fix notification not opening correct topic (issue TGX-Android#14.2)
  Pass messageThreadId through notification intent chain

- Polish share to topic UI with colored icons (issue TGX-Android#13)
  Show colored circle emoji and pin indicator for each topic

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
logopek pushed a commit to logopek/reX that referenced this pull request Jan 5, 2026
@japananimetime @claude
Forum topics: fix mute badge, read receipts, notifications, and polis…
38b518e 
…h share UI

- Fix unread badge not respecting mute state (issue TGX-Android#2)
  Added forumTopicNeedsMuteIcon() to properly check topic/chat mute hierarchy

- Fix forum badge not updating after reading all topics (issue TGX-Android#4)
  Call updateForumTopicUnreadCount() after fetching fresh topic data

- Fix read receipts not showing in topic messages (issue TGX-Android#9)
  Call manager.updateChatReadOutbox() in onForumTopicUpdated

- Fix notification not opening correct topic (issue TGX-Android#14.2)
  Pass messageThreadId through notification intent chain

- Polish share to topic UI with colored icons (issue TGX-Android#13)
  Show colored circle emoji and pin indicator for each topic

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
japananimetime added a commit to japananimetime/Telegram-X that referenced this pull request Jan 17, 2026
@japananimetime @claude
Forum topics: fix mute badge, read receipts, notifications, and polis…
565c92b 
…h share UI

- Fix unread badge not respecting mute state (issue TGX-Android#2)
  Added forumTopicNeedsMuteIcon() to properly check topic/chat mute hierarchy

- Fix forum badge not updating after reading all topics (issue TGX-Android#4)
  Call updateForumTopicUnreadCount() after fetching fresh topic data

- Fix read receipts not showing in topic messages (issue TGX-Android#9)
  Call manager.updateChatReadOutbox() in onForumTopicUpdated

- Fix notification not opening correct topic (issue TGX-Android#14.2)
  Pass messageThreadId through notification intent chain

- Polish share to topic UI with colored icons (issue TGX-Android#13)
  Show colored circle emoji and pin indicator for each topic

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PRs that provide bug fixes

2 participants

@iTaysonLab @vkryl