Added Support for VideoCalls, Screensharing and Optimized CPU Usage during calls by Laky-64 · Pull Request #916 · TGX-Android/Telegram-X

Laky-64 · 2025-08-30T15:04:32Z

The guide below provides the flow for creating a perfect pull request to the Telegram X Repository. Before submitting your PR, ensure that it complies with the following principles.

Screen_Recording_20250830_170141_NTgCallsX.mp4

Perfect PRs must be:

Rational. This PR replaces the old TgCalls implementation with NTgCalls, adding full support for video calls and screen sharing, while also introducing a more efficient CPU usage management. To enable NTgCalls locally, you need to add the following line in your local.properties file:
```
app.ntgcalls=true
```

Completed. All changes have been tested with one-to-one and group calls (both audio and video) as well as screen sharing sessions.
Up-To-Date. The PR is based on the latest commit of the 'main' branch.

When fixing issues, make sure that your PR is:

Sufficient. The new implementation fixes performance bottlenecks in the previous TgCalls integration, addressing high CPU usage and improving stability in long-running calls.
Separated. This PR only focuses on the migration to NTgCalls and the related improvements (video, screen sharing, CPU optimization). Other unrelated fixes are left for separate PRs.
Linked. If there is a specific issue in the tracker about calls performance or missing video support, it should be linked here (e.g., Closes #1234).
Creating. The new features have been tested across multiple devices to ensure they don’t break other parts of the app.
Consistent. Screenshots or video previews should be attached if there are UI changes related to video call and screen sharing interfaces.

When adding features, expect:

Discussion. Open to suggestions regarding UX/UI flow of video calls and screen sharing integration.
Dismissal. Not applicable yet, feature follows Telegram X’s style but can be refined if requested.

Other contributions:

Rational. Optimized the existing call system with better CPU management, ensuring reduced resource consumption during calls.
Improved. Code refactoring makes the call handling logic cleaner, more modular, and easier to maintain.

pdkpv · 2025-08-31T12:24:16Z

Open to suggestions regarding UX/UI flow of video calls and screen sharing integration

In 2021, there was a competition for the design of audio/video calls, and this option seemed the most promising to many: https://contest.com/android-design/entry2997.

Maybe you can somehow come to an agreement with the author and take his design for your implementation.

Cherry-picked Video Calls with Camera and Screen Sharing support. - Added CallInterface abstraction layer - Added NTgCallsInterface and TgCallsInterface implementations - Added VoIPFloatingLayout and VoIPTextureView for video display - Updated CallController with video button support - Updated TGCallService with NTgCalls/TgCalls selection based on BuildConfig.USE_NTGCALLS Based on commit 9513771 from Laky-64/Telegram-X PR TGX-Android#916 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Add BLUETOOTH_CONNECT and BLUETOOTH_SCAN permissions for Android 12+ - Add USE_NTGCALLS BuildConfig flag (controlled by app.ntgcalls in local.properties) - Add useNTgCalls to ApplicationConfig and ConfigurationPlugin - Add conditional NTgCalls dependency (io.github.pytgcalls:ntgcalls:2.0.6) Note: The NTgCalls interface code from PR TGX-Android#916 requires API compatibility updates - the PR was written for a different version of the NTgCalls library with packages (media, p2p, devices, exceptions) that don't exist in the public Maven Central release. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Cherry-picked Video Calls with Camera and Screen Sharing support. - Added CallInterface abstraction layer - Added NTgCallsInterface and TgCallsInterface implementations - Added VoIPFloatingLayout and VoIPTextureView for video display - Updated CallController with video button support - Updated TGCallService with NTgCalls/TgCalls selection based on BuildConfig.USE_NTGCALLS Based on commit 9513771 from Laky-64/Telegram-X PR TGX-Android#916 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Add BLUETOOTH_CONNECT and BLUETOOTH_SCAN permissions for Android 12+ - Add USE_NTGCALLS BuildConfig flag (controlled by app.ntgcalls in local.properties) - Add useNTgCalls to ApplicationConfig and ConfigurationPlugin - Add conditional NTgCalls dependency (io.github.pytgcalls:ntgcalls:2.0.6) Note: The NTgCalls interface code from PR TGX-Android#916 requires API compatibility updates - the PR was written for a different version of the NTgCalls library with packages (media, p2p, devices, exceptions) that don't exist in the public Maven Central release. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Cherry-picked Video Calls with Camera and Screen Sharing support. - Added CallInterface abstraction layer - Added NTgCallsInterface and TgCallsInterface implementations - Added VoIPFloatingLayout and VoIPTextureView for video display - Updated CallController with video button support - Updated TGCallService with NTgCalls/TgCalls selection based on BuildConfig.USE_NTGCALLS Based on commit 9513771 from Laky-64/Telegram-X PR TGX-Android#916 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Add BLUETOOTH_CONNECT and BLUETOOTH_SCAN permissions for Android 12+ - Add USE_NTGCALLS BuildConfig flag (controlled by app.ntgcalls in local.properties) - Add useNTgCalls to ApplicationConfig and ConfigurationPlugin - Add conditional NTgCalls dependency (io.github.pytgcalls:ntgcalls:2.0.6) Note: The NTgCalls interface code from PR TGX-Android#916 requires API compatibility updates - the PR was written for a different version of the NTgCalls library with packages (media, p2p, devices, exceptions) that don't exist in the public Maven Central release. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

hnitgyi034-source

Revert all 8 NTgCalls-related commits. The original developer (Laky-64/null-nick) has made their own proper implementation, so our custom cherry-picked version is no longer needed. Reverted commits: - 3e82450 Add NTgCalls integration from PR TGX-Android#916 - df7b562 Add NTgCalls build configuration and Bluetooth permissions - 2695c8a Add group call support and voice/video restriction UI - 5751cad Add Bluetooth runtime permission checks for Android 12+ - 7c23b5a Add video rendering to GroupCallController - b341699 Add video chat management features - 0169b97 Fix video chat API calls - f544b6d Add Invite to Video Chat feature Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Laky-64 and others added 30 commits October 11, 2024 01:39

Switch to NTgCalls instead of TgCalls

57903fb

Added Video Calls with Camera and Screen Sharing

9513771

Fixed missing permissions

9cc048a

Merge remote-tracking branch 'origin/main' into main-tgcalls

aa2ff70

Updated NTgCalls Library

ba4de35

Fixed NTgCalls Build Variants

0885a5e

Updated R8 Problems

8b88b65

Fixed Android 14+ permissions

69056da

Fixed missing call closing

1dc743f

Fixed Android 14+ camera permissions

d805d57

Switch to the new NTgCalls package name

f6a33e1

Merge remote-tracking branch 'origin/main' into main-tgcalls

33ce035

Updated NTgCalls Interface

74e918c

Fixed missing speaker

a82885a

Use Library from Maven Central

4825b2c

Switch to beta3 of NTgCalls

0257f3f

Return Library Version Name

5819bef

Code Cleanup

ef01057

Updated NTgCalls Version

0553305

Merge remote-tracking branch 'origin/main' into main-tgcalls

d26e5d4

Merge remote-tracking branch 'origin/main' into main-tgcalls

8164b4b

Fixed Wrong P2P Video Codecs

65a485a

Fixed possible "invalid updates"

eb6e8f6

Adapted NTgCalls to use the new beta 15 changes

f60662b

Updated Dependencies

76bca15

Merge remote-tracking branch 'origin/main' into main-tgcalls

7740057

Switch to stable version of NTgCalls

c2aeb83

Merge remote-tracking branch 'origin/main' into main-tgcalls

de44279

Fixed Deprecated NTgCalls Methods

04eb2bb

Updated Dependencies

393b49f

Laky-64 added 5 commits August 24, 2025 21:29

Updates ntgcalls library to version 2.0.6

dc32a4f

Merge remote-tracking branch 'TGX-Android/main'

cb1e9b5

Merge remote-tracking branch 'TGX-Android/main'

78e2fb4

Added Optional NTgCalls Library Usage

6efe484

Fixed Video Calls with latest TgX Update

bbd6883

vkryl force-pushed the main branch from 3c9c99d to 1b11475 Compare October 6, 2025 17:40

vkryl force-pushed the main branch from 058ed53 to 557007a Compare November 2, 2025 00:04

vkryl force-pushed the main branch 3 times, most recently from fbec9a8 to 8bb1443 Compare December 21, 2025 23:57

Merge remote-tracking branch 'upstream'

1617e78

Laky-64 force-pushed the main branch 2 times, most recently from 64777e7 to 225c605 Compare January 22, 2026 12:46

hnitgyi034-source reviewed Jan 31, 2026

View reviewed changes

Laky-64 force-pushed the main branch 2 times, most recently from a1c1b9f to 1617e78 Compare February 2, 2026 02:19

Laky-64 added 5 commits February 2, 2026 10:17

Merge remote-tracking branch 'upstream/main'

944b9c7

Sync submodules with 'upstream/main'

7055da8

Fixed merge conflicts

50b94ed

Sync submodules with 'upstream/main'

48536dd

Upgrades ntgcalls dependency

cd5680e

Conditionally loads tgcallsjni

3af699c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Support for VideoCalls, Screensharing and Optimized CPU Usage during calls#916

Added Support for VideoCalls, Screensharing and Optimized CPU Usage during calls#916
Laky-64 wants to merge 43 commits intoTGX-Android:mainfrom
pytgcalls:main

Laky-64 commented Aug 30, 2025 •

edited

Loading

pdkpv commented Aug 31, 2025

hnitgyi034-source left a comment

Labels

3 participants

Conversation

Laky-64 commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perfect PRs must be:

When fixing issues, make sure that your PR is:

When adding features, expect:

Other contributions:

pdkpv commented Aug 31, 2025

hnitgyi034-source left a comment

Choose a reason for hiding this comment

Labels

3 participants

Laky-64 commented Aug 30, 2025 •

edited

Loading