Fix: correct ESCAPABLE_CHARS in query_lang tokenizer#1334
Merged
Conversation
Replace duplicate double-quote with single-quote so that escaped single quotes inside single-quoted strings are handled correctly (e.g. 'O''Brien' now tokenizes as O'Brien instead of O'Brien). Discovered during automated code review.
Computerdores
approved these changes
Apr 2, 2026
Author
|
closing this out. realized it's way too minor to justify spinning up the CI runs. have a good one. |
github-project-automation
Bot
moved this from 🍃 Pending Merge
to ✅ Done
in TagStudio Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was tracing a parsing issue with names containing apostrophes and noticed the ESCAPABLE_CHARS list had a duplicate double-quote where a single-quote should be. fixed it and verified O'Brien now tokenizes correctly.
Summary
Fixes a tokenizer bug where escaped single-quotes inside single-quoted strings were not handled properly due to a typo in ESCAPABLE_CHARS.
Tasks Completed