Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Tweaks to the dart code - #811

Closed
kevmoo wants to merge 0 commit into
TechEmpower:masterfrom
kevmoo:master
Closed

Tweaks to the dart code#811
kevmoo wants to merge 0 commit into
TechEmpower:masterfrom
kevmoo:master

Conversation

@kevmoo

@kevmoo kevmoo commented Mar 12, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@kevmoo

kevmoo commented Mar 21, 2014

Copy link
Copy Markdown
Contributor Author

Rebased on latest.

@kevmoo

kevmoo commented Apr 4, 2014

Copy link
Copy Markdown
Contributor Author

Ping?

@msmith-techempower

Copy link
Copy Markdown
Member

Excuses time! Just kidding - we are in the midst of wrapping up the data we have for round 9 and will deliver that (hopefully) rather soon. No promises, but we are hoping that round 9 will be done and out the door before much longer which would open the door for us to start merging pull requests for round 10.

Again, sorry for the delay on this, and we are hoping the start merging PRs again soon.

@kevmoo

kevmoo commented Apr 4, 2014

Copy link
Copy Markdown
Contributor Author

No worries. Just checkin.

For Round 9 a couple of questions:

  1. What version of the Dart SDK? 1.2?
  2. What flavor? 32-bit? 64-bit?
@mcocciaTE

Copy link
Copy Markdown
Contributor

when I run dart --version I get

Dart VM version: 1.4.2 (Tue May 27 03:00:04 2014) on "linux_x64" so 1.4.2 and 64?

@kevmoo

kevmoo commented Jun 16, 2014

Copy link
Copy Markdown
Contributor Author

@mcocciaTE Looks like it.

For best performance in these types of benchmarks, please use the 32-bit version of Dart.

1.4.2 is our latest release, so that's great.

@mcocciaTE

Copy link
Copy Markdown
Contributor

I tried to run your tests and got https://gist.github.com/mcocciaTE/e4a298122f1b09601e98 for the error and https://gist.github.com/mcocciaTE/c814da0c2f29eac57b13 for the out file. Basically it looks like it will try as many ports as it can and then ends up just giving a 502 Bad Gateway for all of the test (db, queries, fortune, update, and plaintext).

@hamiltont

Copy link
Copy Markdown
Contributor

@kevmoo - I know it's been quite a while since you originally put this in, thank you for the patience. As @mcocciaTE mentioned, this PR does not run properly. Frankly, this is probably our fault with the huge delay.

However, I come bearing good news - we have setup Travis to automatically run a verification whenever new commits are added to a pull request, so I can promise you there's no more "wait 5 months for the TFB guys to have time to verify my small patch" - if you are willing to add some more commits to this pull request, then Travis will have your verification results within a day.

Here is the link to the travis output logs from your changes so far - it looks like the part that is most relevant to you starts printing errors around line 2975 (e.g. NoSuchMethodError: method not found: 'randomnumber=). Apologies for the huge log dump, I'll be cleaning that up a bit soon.

If you rebase this or add new commits here, the new travis link will show up inline on this pull request.

@kevmoo

kevmoo commented Sep 3, 2014

Copy link
Copy Markdown
Contributor Author

I've created an updated cl that hopefully addresses things: #1078

@kevmoo kevmoo closed this Sep 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

5 participants