Tweaks to the dart code - #811
Conversation
|
Rebased on latest. |
|
Ping? |
|
Excuses time! Just kidding - we are in the midst of wrapping up the data we have for round 9 and will deliver that (hopefully) rather soon. No promises, but we are hoping that round 9 will be done and out the door before much longer which would open the door for us to start merging pull requests for round 10. Again, sorry for the delay on this, and we are hoping the start merging PRs again soon. |
|
No worries. Just checkin. For Round 9 a couple of questions:
|
|
when I run dart --version I get Dart VM version: 1.4.2 (Tue May 27 03:00:04 2014) on "linux_x64" so 1.4.2 and 64? |
|
@mcocciaTE Looks like it. For best performance in these types of benchmarks, please use the 32-bit version of Dart. 1.4.2 is our latest release, so that's great. |
|
I tried to run your tests and got https://gist.github.com/mcocciaTE/e4a298122f1b09601e98 for the error and https://gist.github.com/mcocciaTE/c814da0c2f29eac57b13 for the out file. Basically it looks like it will try as many ports as it can and then ends up just giving a 502 Bad Gateway for all of the test (db, queries, fortune, update, and plaintext). |
|
@kevmoo - I know it's been quite a while since you originally put this in, thank you for the patience. As @mcocciaTE mentioned, this PR does not run properly. Frankly, this is probably our fault with the huge delay. However, I come bearing good news - we have setup Travis to automatically run a verification whenever new commits are added to a pull request, so I can promise you there's no more "wait 5 months for the TFB guys to have time to verify my small patch" - if you are willing to add some more commits to this pull request, then Travis will have your verification results within a day. Here is the link to the travis output logs from your changes so far - it looks like the part that is most relevant to you starts printing errors around line 2975 (e.g. If you rebase this or add new commits here, the new travis link will show up inline on this pull request. |
|
I've created an updated cl that hopefully addresses things: #1078 |
No description provided.