add example with dynamic group of progress bars #1504
Conversation
willmcgugan
left a comment
willmcgugan
left a comment
There was a problem hiding this comment.
Looks good! Couple of small requests.
Could you run this against the latest black?
examples/dynamic_progress.py
Outdated
|
|
||
| import time | ||
|
|
||
| from rich.console import RenderGroup |
There was a problem hiding this comment.
RenderGroup was deprecate, the new name is just Group
examples/dynamic_progress.py
Outdated
| ) | ||
| # group of progress bars; | ||
| # some are always visible, others will disappear when progress is complete | ||
| group = RenderGroup( |
There was a problem hiding this comment.
Should be Group here. Could you also give group a more descriptive name?
|
Nice work! Could you maybe put the app progress in a Panel to separate it visually? And speed it up a fraction... |
|
Any chance you can have another look at this? |
boegel
force-pushed
the
dynamic_progress_example
branch
from
014adfb to
28a33cb
Compare
Sorry for not getting back to this sooner. Requested changes done, and rebased on latest |
|
@willmcgugan Anything in particular that's blocking this PR? Happy to make additional changes if needed. |
|
Sorry, forgot about this one. Looks good. Thanks! |
2 participants
Type of changes
Checklist
Description
Additional example for progress bars, more dynamic in nature than the existing live_progress.py; see also discussion in #1500 .
Screenshot while running:
Screenshot when done: