Conversation
added hydration checking to write_twint_enriched_tweetdf_to_neo
improved twint url parser and mention parser functionality.
lmeyerov
reviewed
Aug 28, 2020
| self.tweetsandaccounts = """ | ||
| UNWIND $tweets AS t | ||
| //Add the Tweet | ||
| //Add the Tweet |
Contributor
There was a problem hiding this comment.
A lot of whitespace edits -- you may want to check your editor and start using git add -p to be more selective
lmeyerov
reviewed
Aug 28, 2020
| else: | ||
| return df.head(limit) | ||
| rdf = df.head(limit) | ||
| return rdf |
Contributor
There was a problem hiding this comment.
limit can be None, causing this to fail
lmeyerov
reviewed
Aug 28, 2020
| def save_twintdf_to_neo(self, df, job_name, job_id=None): | ||
|
|
||
| df = TwintPool().twint_df_to_neo4j_df(df) | ||
| df.drop(df.columns[df.columns.str.contains('unnamed', case=False)], axis=1, inplace=True) |
Contributor
There was a problem hiding this comment.
unnamed suggests there is a bug before this line is reached..
lmeyerov
reviewed
Aug 28, 2020
|
|
||
|
|
||
| except: | ||
| raise |
lmeyerov
reviewed
Aug 28, 2020
|
|
||
| except: | ||
| raise | ||
| url_df = pd.concat([df for df in url_params_lst], axis=0, ignore_index=True, sort=False) |
Contributor
There was a problem hiding this comment.
pd.concat(url_params_lst, ignore_index=True, sort=False)
…ment df to neo in twint writer
…ment df to neo in twint writer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first patch that includes twint tweet to neo4j conversion