Added a few more convenience commands#139
Merged
Jimmacle merged 7 commits intoTorchAPI:masterfrom Nov 26, 2019
LordTylus:master
Merged
Added a few more convenience commands#139Jimmacle merged 7 commits intoTorchAPI:masterfrom LordTylus:master
Jimmacle merged 7 commits intoTorchAPI:masterfrom
LordTylus:master
Conversation
…nd improved it a little to deal with offline players as well.
Contributor
Author
|
Seems like eject and kill are already present and need some improvements. Which I now did. Please reevaluate |
LordTylus
commented
Nov 24, 2019
Comment on lines
-266
to
+288
| c.RemoveUsers(false); | ||
| //Context.Respond($"Ejected {parent.DisplayName} from seat."); | ||
| continue; | ||
| controller.Use(); |
Contributor
Author
There was a problem hiding this comment.
I have not tested if RemoveUsers works fine or not. Use seems to do the job very well for what I have Tested in my previous commit. So I did not see a reason to revert it back to RemoveUsers.
Jimmacle
requested changes
Nov 25, 2019
Member
Jimmacle
left a comment
Jimmacle
left a comment
There was a problem hiding this comment.
Overall good, I appreciate the commenting. There are just a few style things to change to stay consistent with the rest of the code
| using VRage.Groups; | ||
| using VRageMath; | ||
|
|
||
| namespace ALE_Core.Utils { |
Member
There was a problem hiding this comment.
The bracket style is inconsistent with the rest of the Torch codebase, I'd also prefer this to be in an Essentials namespace
| Teleport(entityToMove, destination); | ||
| } | ||
|
|
||
| [Command("tphere", "Teleport an other entity directly to you.")] |
Jimmacle
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we already had a tpto command I thought it may be useful to also have tphere command.
A thing I want to try to change however is dealing with players that are seated in the cockpit. Which currently I have not done. Its nice to be able to tp grids or to grids, but if you want to tp to a player inside a grid its still broken :-(
There also now is a command to eject a given player from any seat. Since we had instances on our server where a player was stuck he had to disconnect so we could delete his character from the game and then he could reconnect. An eject command shall improve that. However as everything with essentials it wont work with offline players.
Same goes for the new kill command.
Since you cannot eject offline players we also now have a grids ejectall command where you can either call it by passing a gridname or like my ALE plugins by looking at them.
The GridFinder is a copy from my ALE Core