Skip to content

Code Cleanup of the entire code#149

Closed
SKO85 wants to merge 3 commits intoTorchAPI:masterfrom
SKO85:fix/code-cleanup
Closed

Code Cleanup of the entire code#149
SKO85 wants to merge 3 commits intoTorchAPI:masterfrom
SKO85:fix/code-cleanup

Conversation

@SKO85
Copy link
Copy Markdown
Contributor

@SKO85 SKO85 commented Apr 23, 2020

  • Cleaned up all code.
  • Reorganised code and made it a bit more consistent.
  • Removed unused using-statements.
@rexxar-tc
Copy link
Copy Markdown
Contributor

This will not be merged.

This pull request seems to be the result of running ReSharper or another similar code formatting tool. In general, this type of pull request is frowned upon in the open source community. This kind of pull request generates far more work for the project maintainer, as I would have to manually review 700 line changes across 23 files, which will take way more time than it's worth, especially considering I can run a cleanup tool on my own in just a few minutes.

While cleanup PRs do have a time and place, you must start from a clean copy of master, and have no other changes or additions. This branch appears to contain code additions, which cannot be accepted as part of a cleanup pull request. This is mostly because it becomes impossible to track down and revert code additions when there are this many changes.

I do appreciate you wanting to contribute. However, we won't be accepting any cleanup PRs, as this entire project is going to be refactored or rewritten in the near future.

@rexxar-tc rexxar-tc closed this Apr 23, 2020
@SKO85 SKO85 deleted the fix/code-cleanup branch April 23, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants