Null-Check for GeneratorInstance#177
Merged
Bishbash777 merged 1 commit intoTorchAPI:masterfrom Mar 7, 2021
Merged
Conversation
If SEWorldGenerator Plugin is used or Procedural Seed is 0 there will be no GeneratorInstance. In this case this Method will NRE. However we still would like to delete stuff. So just return null. Because when there is no GeneratorInstance we dont have to tell itentities are being deleted. Luckily the IDisposable in the using() block is Nullable :-)
dorimanx
pushed a commit
to dorimanx/Essentials
that referenced
this pull request
Jun 17, 2021
If SEWorldGenerator Plugin is used or Procedural Seed is 0 there will be no GeneratorInstance. In this case this Method will NRE. However we still would like to delete stuff. So just return null. Because when there is no GeneratorInstance we dont have to tell itentities are being deleted. Luckily the IDisposable in the using() block is Nullable :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If SEWorldGenerator Plugin is used or Procedural Seed is 0 there will be no GeneratorInstance. In this case this Method will NRE.
However we still would like to delete stuff. So just return null. Because when there is no GeneratorInstance we dont have to tell itentities are being deleted.
Luckily the IDisposable in the using() block is Nullable :-)
Kontu Tested that stuff and was pleased that it worked