added hasgridtype condition#180
Merged
Bishbash777 merged 1 commit intoTorchAPI:masterfrom Mar 7, 2021
Merged
Conversation
When using !cleanup delete hasownertype npc everything will be deleted that is npc owned, so stations and ships. This is not a good behavior as NPC stations that are protected by safezoned may not want to be deleted. You of course can remove them and use the shitty commands to remove the now empty safezones as well but players may want to expect a consistent location of these NPCs, as common points of interest. So with this new condition you can !cleanup delete hasownertype npc hasgridtype ship which will only remove npc ships and leave the stations. Similar to all other conditions a grid will only be deleted if all subgrids match this condition. So it works best for ships, as all subgrids of a ship usually are ships as well. However a station with a rotor head wont be removed by "static" condition as long as the rotor head is there. This could be changed in the future but personally I dont think its needed to build something inconsistent there.
dorimanx
pushed a commit
to dorimanx/Essentials
that referenced
this pull request
Jun 17, 2021
When using !cleanup delete hasownertype npc everything will be deleted that is npc owned, so stations and ships. This is not a good behavior as NPC stations that are protected by safezoned may not want to be deleted. You of course can remove them and use the shitty commands to remove the now empty safezones as well but players may want to expect a consistent location of these NPCs, as common points of interest. So with this new condition you can !cleanup delete hasownertype npc hasgridtype ship which will only remove npc ships and leave the stations. Similar to all other conditions a grid will only be deleted if all subgrids match this condition. So it works best for ships, as all subgrids of a ship usually are ships as well. However a station with a rotor head wont be removed by "static" condition as long as the rotor head is there. This could be changed in the future but personally I dont think its needed to build something inconsistent there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using !cleanup delete hasownertype npc everything will be deleted that is npc owned, so stations and ships. This is not a good behavior as NPC stations that are protected by safezoned may not want to be deleted.
You of course can remove them and use the shitty commands to remove the now empty safezones as well but players may want to expect a consistent location of these NPCs, as common points of interest.
So with this new condition you can
!cleanup delete hasownertype npc hasgridtype ship
which will only remove npc ships and leave the stations.
Similar to all other conditions a grid will only be deleted if all subgrids match this condition. So it works best for ships, as all subgrids of a ship usually are ships as well. However a station with a rotor head wont be removed by "static" condition as long as the rotor head is there.
This could be changed in the future but personally I dont think its needed to build something inconsistent there.