Fix for NRE on Essentials unload & Removed bad client join tweaks code#191
Fix for NRE on Essentials unload & Removed bad client join tweaks code#191Bishbash777 merged 3 commits intoTorchAPI:masterfrom Casimir255:master
Conversation
|
Originally fixed the NRE on essentials logs.
The above error throws when the game failed to load properly, and essentials tries to unload. This confuses users and blames essentials. Instead, allow essentials to only unload once it was fully initialized. Then the source of the error should still be thrown and investigated further than just the essentials error. I removed the client join tweaks code. When enabled may be helpful for some, but most use cases just throws an error and then people complain in torch discord why they cant join their server. 9/10 issues in torch is because of this issue... Therefore I removed it. Instead in its place, I added a client request WorldData cleaner. This removes/purges extra junk the target client doesnt need. Should reduce the sandbox size for sending to the client, and lets the game's code do the rest in parallel due to the recent changes in the client world request area. |
|
Thank you Casimir255 for this change, i agree with you, Client Tweaks should go, it's no longer used, and when used, only create issues that always resolved by "Disable this! and forget about it" |
|
This change is running on our 6 servers for more than a moth! as it's good! no issues and login to server is improved, please merge this change for all! |
Only remove events if the server fully started.