Conditions now can be used by other plugins#210
Merged
Bishbash777 merged 3 commits intoTorchAPI:masterfrom Jun 11, 2023
Merged
Conversation
To make other plugins to be able extend you need
1) Define class that is marked [ConditionModule]
2) Add method in that class is marked by [Condition("name", helpText: "tooltip")]
3) Method should return bool, and accept MyCubeGrid. It may also accept 1 extra param (string, double, int ...)
Contributor
Author
|
Commands.zip |
hastype-fast/notype-fast hassubtype-fast/nosubtype-fast Same as without "-fast", but also support multiple types/subtypes
|
This looks great! fresh code, much more organized, but.. is it production ready? If i will send command, and server crash, that is not acceptable, is it tested for all possible bugs? I am offering my help to test commands, on our test server, i will try all of them, and report findings. Thank you! |
Contributor
Author
|
Try executing it with errors. |
dorimanx
pushed a commit
to dorimanx/Essentials
that referenced
this pull request
Nov 7, 2024
* Conditions now can be used by other plugins
To make other plugins to be able extend you need
1) Define class that is marked [ConditionModule]
2) Add method in that class is marked by [Condition("name", helpText: "tooltip")]
3) Method should return bool, and accept MyCubeGrid. It may also accept 1 extra param (string, double, int ...)
* Added new commands (optimization)
hastype-fast/notype-fast
hassubtype-fast/nosubtype-fast
Same as without "-fast", but also support multiple types/subtypes
* Parallel iterate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make other plugins to be able extend you need
Define class that is marked [ConditionModule]
Add method in that class is marked by [Condition("name", helpText: "tooltip")]
Method should return bool, and accept MyCubeGrid. It may also accept 1 extra param (string, double, int ...)