Skip to content

Several Bugfixes in EcoCommands #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bishbash777 merged 6 commits into from
Dec 31, 2023
Merged

Several Bugfixes in EcoCommands #212

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c76055d
Fix: It possible KeyAlreadyExistException workarounded
LordTylus Dec 29, 2023
d02b80a
Fix: Credits are Number-Formatted in all eco commands
LordTylus Dec 29, 2023
f1beb8b
Fix: Players can nolonger pay themselves
LordTylus Dec 30, 2023
69b0b46
Fix: Added missing .DisplayName when Paying player
LordTylus Dec 30, 2023
59e6ad2
Feat: !econ check can now also check offline players
LordTylus Dec 30, 2023
689436a
Fix: Responses now inform about the possability that the player is of…
LordTylus Dec 30, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Feat: !econ check can now also check offline players 
I dont exactly know why that limitation of online only was in place. set, take, give, check should work for offlines too.

Since the others are not important enough (for me at least) I am not doing that with this commit.
  • Loading branch information
@LordTylus
LordTylus committed Dec 30, 2023
commit 59e6ad21812a0138c3e94daf2f2f1774ca94af6c
6 changes: 3 additions & 3 deletions Essentials/Commands/EcoModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,12 @@ public void EcoTop() {
[Command("check", "Check the balance of a specific player")]
[Permission(MyPromoteLevel.None)]
public void EcoCheck(string Player) {
var p = Utilities.GetPlayerByNameOrId(Player);
var p = Utilities.GetIdentityByNameOrIds(Player);
if (p == null) {
Context.Respond("Player is not online or cannot be found!");
Context.Respond("Player cannot be found!");
return;
}
long balance = MyBankingSystem.GetBalance(p.Identity.IdentityId);
long balance = MyBankingSystem.GetBalance(p.IdentityId);
Context.Respond($"{p.DisplayName}'s balance is {balance:#,##0} credits");
}

Expand Down