Check for NPC on ownedby condition#55
Merged
rexxar-tc merged 5 commits intoTorchAPI:masterfrom Aug 24, 2018
Merged
Conversation
Added a check to Keen's mysterious NPC Identity list, since NPCs cannot be found with MySession.Static.Players.TryGetPlayerById
rexxar-tc
suggested changes
Aug 23, 2018
| if(long.TryParse(str, out long NPCId)) | ||
| { | ||
| if(MySession.Static.Players.IdentityIsNpc(NPCId)) | ||
| { |
Contributor
There was a problem hiding this comment.
You'll get a null reference exception if this statement is false. Remove the else on L291
rexxar-tc
approved these changes
Aug 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check to Keen's mysterious NPC Identity list, since NPCs cannot be found with MySession.Static.Players.TryGetPlayerById