Fix dependent DLL loading#167
Merged
Equinox- merged 3 commits intoTorchAPI:stagingfrom Nov 7, 2017
Merged
Conversation
… zips I had several Xy.dll.xml files there and it was tried to be loaded as an Assembly.
Let Torch to load the plugin's assembly.
When there are dependencies among a plugin's DLLs, those dependencies needs a custom resolving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a bunch of fixes, the main issue was that I'm using a package from NuGet in my plugin. But that package has other NuGet package dependencies, and those packages have more dependencies, ... etc.
Those DLLs need to be loaded in a proper order, I implemented it with the AssemblyResolve event.
Other fixes: