Skip to content

InfluxDB.Client Integration for Server Health Monitoring#409

Closed
ryo0ka wants to merge 1 commit intoTorchAPI:masterfrom
HnZGaming:export
Closed

InfluxDB.Client Integration for Server Health Monitoring#409
ryo0ka wants to merge 1 commit intoTorchAPI:masterfrom
HnZGaming:export

Conversation

@ryo0ka
Copy link
Copy Markdown
Contributor

@ryo0ka ryo0ka commented Nov 1, 2020

This PR adds dependency to InfluxDB.Client and some bridge classes for easy consumption by plugins such as TorchMonitor.

Screenshot 2020-11-02 025502

Why InfluxDB?

  1. Fank has made a monitoring program with InfluxDB which had familiarized SE admin community with this library.
  2. InfluxDB is a MIT-licensed open-sourced project, with an active body of developers, users and online resource.
  3. Fairly easy to get going and scale later.

Alternative choice of database: Elasticsearch can handle more types and schemes of data. Please ask Kontu's team. Our Torch fork does have Elasticsearch integrated as well (not included in this PR).

Why Integrate Database to Torch?

The admin community's strong interest toward a nice-looking monitoring dashboard. Easy access to database will be the first step forward to everyone's dream. Higher standard of understanding to the game and players shall enlighten our minds...🧙‍♂️

@Jimmacle
Copy link
Copy Markdown
Member

Jimmacle commented Nov 3, 2020

This looks nice, however it seems like a relatively standalone feature that would be better suited as a plugin. Is there any reason besides easy consumption that it should be merged into Torch itself?

@ryo0ka
Copy link
Copy Markdown
Contributor Author

ryo0ka commented Nov 4, 2020

@Jimmacle Actually no other reasons. This is just my best effort to share my server's tools for some other admins who want to try it but can't code/build by themselves.

I can turn this into a standalone plugin; it'll only take some tweaking to the libraries, in other words fighting the dependency and keeping it updated somehow. This PR's solution is dump it on MSBuild and call it a day. My defense argument is that the product is somewhat popular in the community and an "easy consumption" of the product is dreamed enough to justify the integration.

Context to this PR (discussion on Discord)

@ryo0ka
Copy link
Copy Markdown
Contributor Author

ryo0ka commented Nov 12, 2020

Closed as I implemented a standalone plugin

@ryo0ka ryo0ka deleted the export branch November 27, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants