Added async /save command for admins+ and server console.#42
Merged
Jimmacle merged 3 commits intoTorchAPI:masterfrom Jul 6, 2017
Merged
Added async /save command for admins+ and server console.#42Jimmacle merged 3 commits intoTorchAPI:masterfrom
Jimmacle merged 3 commits intoTorchAPI:masterfrom
Conversation
Redesigned TorchBase.SaveGameAsync to take a callback function for error/success handling. Also removed local host checks as we are hosting a dedicated server.
Jimmacle
requested changes
Jul 6, 2017
Member
Jimmacle
left a comment
Jimmacle
left a comment
There was a problem hiding this comment.
Looks good in general, I commented on a few things that should be changed. In addition, please add ///summary documentation to all of the non-private members/types you added.
|
|
||
| if (!MySandboxGame.IsGameReady) | ||
| { | ||
| callback(SaveGameStatus.GameNotReady); |
Member
There was a problem hiding this comment.
Actions should be null checked in the beginning of the method or invoked like action?.Invoke() to avoid NREs when the action is null.
|
|
||
| namespace Torch | ||
| { | ||
| public enum SaveGameStatus : byte |
Member
There was a problem hiding this comment.
This should be moved to its own file.
| Log.Error("Save failed!"); | ||
| Multiplayer.SendMessage("Save timed out!", "Error"); | ||
| callback(SaveGameStatus.Success); | ||
| return; |
Member
There was a problem hiding this comment.
Double check this, return; is not in the conditional and the callback will never be called with SaveGameStatus.TimedOut.
Contributor
Author
|
Fixed the issues you mentioned and resolved a merge conflict introduced with the latest update to Torch. |
Jimmacle
approved these changes
Jul 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also redesigned TorchBase.SaveGameAsync to take a callback function for error/success handling. Also removed local host checks as we are hosting a dedicated server.