Added alternative exception handling for nogui implementation#478
Closed
Synirrr wants to merge 0 commit intoTorchAPI:masterfrom
Closed
Added alternative exception handling for nogui implementation#478Synirrr wants to merge 0 commit intoTorchAPI:masterfrom
Synirrr wants to merge 0 commit intoTorchAPI:masterfrom
Conversation
Author
|
Rationale for the change is that when no gui is set users would expect any UI elements to not be rendered during any aspect of the application running. So having a message box pop up that hangs the process unless a user selects "Okay" seems counterintuitive to the no gui setting. |
zznty
suggested changes
Apr 24, 2022
Contributor
zznty
left a comment
zznty
left a comment
There was a problem hiding this comment.
i would suggest to move LogManager.Flush() after your logging because message can not appear in some cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to how exceptions are handled when no-gui is selected.