Session Settings View Model Refactor#601
Merged
Bishbash777 merged 1 commit intoTorchAPI:masterfrom May 11, 2025
Merged
Conversation
Added missing settings, rearranged code layout to a cleaner layout, changed names and descriptions of certain settings to match vanilla dedicated server GUI, and rearraged group assignments match vanilla dedicated server GUI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing settings, rearranged code layout to a cleaner layout, changed names and descriptions of
certain settings to match vanilla dedicated server GUI, and rearraged group assignments match vanilla dedicated server GUI.
Torch should now have settings that match the vanilla dedicated server GUI. There were at least 10+ settings that were missing in Torch's GUI.
The git changes may look messy, but I basically rewote the whole file as I was going through the settings in the vanilla dedicated server GUI. It may be better to look at the modified file itself to review.
Possible long term solution:
The view model could be rewitten where the settings are dynamically generated from the attributes on the members in
MyObjectBuilder_SessionSettings, this would prevent issues where new settings are forgotten, and would allow settings to be removed and added without updating this file