Removed memberWelcomeEmailSendInstantly configuration parameter

[cmraible]

ref https://linear.app/ghost/issue/NY-964/cleanup-remove-welcomeemailsendinstantly-configuration

Initially the process outbox job would run at most every 5 minutes, so we created this memberWelcomeEmailSendInstantly configuration parameter to run the job much more frequently for the sake of our e2e tests. We've since updated the implementation so the process-outbox job is triggered immediately when a member signs up anyways, so this configuration parameter is now redundant and unnecessary.

[coderabbitai]

Walkthrough

This change removes the memberWelcomeEmailSendInstantly configuration property from the Ghost codebase. The property is eliminated from the test fixture configuration in e2e/helpers/playwright/fixture.ts and the outbox job scheduling logic in ghost/core/core/server/services/outbox/jobs/index.js. The removal simplifies the cron schedule computation by eliminating the conditional branch that previously toggled behavior based on this configuration. Documentation and example usage are updated to reflect these changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: removing the memberWelcomeEmailSendInstantly configuration parameter, which is the primary focus of both modified files.
Description check	✅ Passed	The description explains the purpose and rationale for the change, relating directly to the removal of the memberWelcomeEmailSendInstantly parameter across the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cmraible]

Still planning to do this, but this isn't the right way to do it 😅