Cleaned up CustomRedirectsAPI unit tests

[EvanHahn]

This test-only change should have no user impact.

This makes two changes to the CustomRedirectsAPI tests:

1. Instead of using try, use assert.throws() or just call the function.
2. Switch from Should.js to node:assert/strict and Sinon assertions.

[coderabbitai]

Walkthrough

This pull request refactors a unit test file to migrate from the should assertion library to node:assert/strict and sinon.assert helpers. The changes systematically replace should-based assertions with their equivalent assert and sinon counterparts throughout the test suite, including deepEqual checks, existence checks, boolean assertions, error handling via assert.rejects, and spy call verification. No production code or test logic is modified; only the assertion mechanisms are updated.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: cleaning up CustomRedirectsAPI unit tests by migrating assertion libraries.
Description check	✅ Passed	The description clearly explains the two main changes (replacing try blocks and switching assertion libraries) and notes the test-only nature with no user impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 21494481869 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"