[TT-16529] Add cache_hit field to Gateway access logs #7717
+112
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new `cache_hit` field to the access logs that indicates whether a response was served from the cache. Changes: - Add CacheHit context key in ctx/ctx.go - Add ctxSetCacheHit/ctxGetCacheHit functions in gateway/api.go - Set cache_hit flag to true in mw_redis_cache.go when serving from cache - Add WithCacheHit method to accesslog.Record - Update RecordAccessLog to include cache_hit field - Add RecordAccessLog call for cached responses in mw_redis_cache.go - Add table-driven unit tests for cache_hit field The cache_hit field will be: - true: when the response is served from the Redis cache - false: when the response is fetched from the upstream service Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
cache_hitfield to the Tyk Gateway access logs that indicates whether a response was served from the cache.CacheHitcontext key for passing cache status through request contextcache_hit=truein Redis cache middleware when serving cached responsescache_hitfield in all access log entries (defaults tofalsefor non-cached responses)Test plan
go test ./internal/httputil/accesslog/...)go build ./ctx/... ./gateway/... ./internal/httputil/accesslog/...)go vet ./gateway/...)cache_hit=truewhen response is served from cachecache_hit=falsewhen response is from upstreamRelated Issues
🤖 Generated with Claude Code