Skip to content

fix: zh-tw 日志 to 日誌 #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yingang merged 2 commits into from
Nov 23, 2023
Merged

fix: zh-tw 日志 to 日誌 #335

yingang merged 2 commits into from
Nov 23, 2023

Conversation

@kimi0230
Copy link
Contributor

@kimi0230 kimi0230 commented Nov 23, 2023

typo in zh-tw

change 日志 to 日誌
@yingang
Copy link
Collaborator

yingang commented Nov 23, 2023 •
edited
Loading

你好，感谢指出问题！这里的繁体中文版本是基于OpenCC自动转换的，其中处理不当的地方现在是通过在转换脚本里加特例来临时处理的。

问下是否方便参照脚本来提交此PR？https://github.com/Vonng/ddia/blob/master/bin/zh-tw.py
@kimi0230
Copy link
Contributor Author

kimi0230 commented Nov 23, 2023 •
edited
Loading

@yingang
好的, 沒問題
已修改 script
謝謝!
@yingang yingang merged commit 27971a3 into Vonng:master Nov 23, 2023
@yingang
Copy link
Collaborator

yingang commented Nov 23, 2023

已合并，感谢~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@kimi0230 @yingang