Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Abstract out POST /wp/v2/media permissions check - #2003

Merged
rachelbaker merged 2 commits into
developfrom
922-attachment-create-item-permissions
Jan 12, 2016
Merged

Abstract out POST /wp/v2/media permissions check#2003
rachelbaker merged 2 commits into
developfrom
922-attachment-create-item-permissions

Conversation

@danielbachhuber

@danielbachhuber danielbachhuber commented Jan 12, 2016

Copy link
Copy Markdown
Member

Fixes #922
@danielbachhuber danielbachhuber added this to the 2.0 Beta 11 milestone Jan 12, 2016
@danielbachhuber

danielbachhuber commented Jan 12, 2016

Copy link
Copy Markdown
Member Author

@WP-API/amigos #reviewmerge
@rachelbaker

rachelbaker commented Jan 12, 2016

Copy link
Copy Markdown
Member

@danielbachhuber Are there any unit tests needed to make sure the permission check logic works as expected?
@danielbachhuber

danielbachhuber commented Jan 12, 2016

Copy link
Copy Markdown
Member Author

Are there any unit tests needed to make sure the permission check logic works as expected?

It's covered by existing tests test_create_item_invalid_upload_files_capability and test_create_item_invalid_edit_permissions
rachelbaker added a commit that referenced this pull request Jan 12, 2016
@rachelbaker
Merge pull request #2003 from WP-API/922-attachment-create-item-permi…
33377f6 
…ssions

Abstract out `POST /wp/v2/media` permissions check
@rachelbaker
rachelbaker merged commit 33377f6 into develop Jan 12, 2016
@rachelbaker
rachelbaker deleted the 922-attachment-create-item-permissions branch January 12, 2016 22:37
@dave-green-uk dave-green-uk mentioned this pull request Jun 26, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Review

2 participants

@danielbachhuber @rachelbaker