Skip to content

Add notice when pretty permalinks are not being used - #33

Open
salcode wants to merge 1 commit into
WP-API:masterfrom
salcode:warning-plain-permalinks-32
Open

Add notice when pretty permalinks are not being used#33
salcode wants to merge 1 commit into
WP-API:masterfrom
salcode:warning-plain-permalinks-32

Conversation

@salcode

@salcode salcode commented Dec 4, 2016

Copy link
Copy Markdown

screenshot 2016-12-04 12 36 38

See #32
@joehoyle

joehoyle commented Dec 4, 2016

Copy link
Copy Markdown
Member

We should just fix working without permalinks
@salcode

salcode commented Dec 4, 2016 •
edited
Loading

Copy link
Copy Markdown
Author

@joehoyle That is a great idea but I'd still like to see this warning put in place as a temporary fix (until it works without pretty permalinks)
@salcode

salcode commented Dec 7, 2016

Copy link
Copy Markdown
Author

Now that WP 4.7 is out with the REST API in it - congratulations! Along with this, I'm guessing this plugin will increase in popularity.

On Sunday I was at WCUS's contributor day. When I decided to contribute to core I started out with this plugin on a fresh install to test endpoints and I got this cryptic error. I then posted a message to slack and got no response. I finally asked one of the organizers regarding testing the endpoints about this error and the suggestion I got was to use a different tool to test the endpoints. This was a lousy user experience, which is bad for the REST API reputation and WordPress's reputation.

Adding this notice will prevent others from having a similar experience.

I won't badger any further regarding this PR but I wanted to share my motivation for it.

Cheers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@salcode @joehoyle