chore: Update target WordPress version to 7.0 and minimum PHP to 7.4.0 - #70
Conversation
…nd PHP 7.4.0 across all skills and references
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
karmatosed
left a comment
karmatosed
left a comment
There was a problem hiding this comment.
The PR does the right thing for the compatibility baseline (default target WP 7.0 + PHP 7.4.0), but it also incorrectly rewrites historical release notes where features actually shipped in 6.9, not 7.0.
AI parsed mistakes, please check for all:
PR #70 mistakes
Incorrect 6.9 → 7.0 rewrites (features shipped in 6.9)
skills/wp-interactivity-api/SKILL.md — “WordPress 6.9 changes” renamed to 7.0; data-wp-ignore deprecation, unique directive IDs, and navigation/attachTo notes are 6.9 features.
skills/wp-interactivity-api/references/debugging.md — Section “WordPress 6.9 specific issues” renamed to 7.0; data-wp-ignore deprecated in 6.9, not 7.0; attachTo added in 6.9, not 7.0.
skills/wp-interactivity-api/references/directives-quickref.md — “Unique directive IDs (WordPress 6.9+)” renamed to 7.0+; data-wp-ignore deprecation date changed from 6.9 to 7.0.
skills/wp-block-development/SKILL.md — apiVersion: 3 requirement described as “WordPress 7.0+”; it was enforced in 6.9.
skills/wp-block-development/references/block-json.md — “WordPress 6.9+ requires apiVersion 3” changed to 7.0+.
skills/wp-block-development/references/debugging.md — “Console warnings about apiVersion (WordPress 6.9+)” changed to 7.0+.
skills/wp-block-themes/references/theme-json.md — “WordPress 6.9 additions” (form element styling, border radius presets) renamed to 7.0; “not yet available in 6.9” changed to 7.0.
skills/wp-performance/SKILL.md — “WordPress 6.9 performance improvements” (on-demand CSS for classic themes) renamed to 7.0.
skills/wp-abilities-api/SKILL.md — “If the project targets WP < 6.9” changed to < 7.0; Abilities API is in core since 6.9, so the plugin fallback threshold should stay at 6.9.
skills/wp-abilities-verify/references/runtime-harness.md — “WordPress version >= 6.9 (Abilities API available in core)” changed to 7.0; wp_get_abilities check “WP >= 6.9” changed to 7.0.
Scope / overlap issues
shared/references/wordpress-core-versions.json — Manually edited in this PR; that file is owned by the upstream sync workflow (PR #55). This PR’s copy is also incomplete/stale (e.g. still has 6.0.11 instead of 6.0.12).
What should have changed (for contrast)
compatibility: frontmatter in all skills
README.md, CONTRIBUTING.md, docs/compatibility-policy.md
eval/harness/run.mjs
shared/scripts/scaffold-skill.mjs
Default/threshold language like “target 7.0+” or “if below 7.0, call out” where it refers to the new baseline, not when a feature shipped
…ore-versions.json
|
Hey @karmatosed Thanks for the detailed review, I've addressed all the feedback in the latest commit. |
karmatosed
left a comment
karmatosed
left a comment
There was a problem hiding this comment.
Thank you for the iterations, now approving. We need to wait for one more review so pinging @WordPress/agent-skills-maintainers to get that for you.
bgrgicak
left a comment
bgrgicak
left a comment
There was a problem hiding this comment.
Thanks for contributing @NoumaanAhamed!
Let's merge this PR as is, but long term, we should find a way for the version bumps to be automated.
…, #13, WordPress#18) Brings in upstream commits aecc4d6, 20324d2, 8182820, c212346 while keeping the fork's contracts: - Kept the two-floor compatibility policy (docs/compatibility-policy.md) over upstream WordPress#70's blanket WP 7.0+/PHP 7.4.0+ bump: all SKILL.md frontmatter, eval/harness/run.mjs, scaffold-skill.mjs, and docs resolve to the fork side; CONTRIBUTING.md and README.md now state the two-floor policy explicitly instead of inheriting the flat bump - Kept the fork's fresher upstream indices (WP 7.0.2 / GB snapshot) over upstream WordPress#55's older refresh - Kept the fork's Antigravity (#13) and wp-patterns (WordPress#18) copies, both already adapted in PR #10; upstream's versions differ only in comments, usage text, and wp-patterns frontmatter - Accepted upstream's WP 7.0 example env line in wp-abilities-verify/references/runtime-harness.md Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4 participants
What does this PR do?
Updates the default compatibility targets across all Agent Skills, documentation, and the evaluation harness to assume WordPress 7.0 and PHP 7.4.0 as the baseline.
Why is this change necessary?
WordPress 7.0 ("Armstrong") has officially retired support for PHP 7.3 and below, making PHP 7.4.0 the hard minimum. To ensure the agents generate safe, actively maintained, and compatible code, the skills' compatibility contracts have been bumped from WP 6.9+ (PHP 7.2.24+) to WP 7.0+ (PHP 7.4.0+).
Addresses #68