Remove Pattern Saving Option - #765
Closed
pbking wants to merge 5 commits into
Closed
Conversation
Contributor
Author
|
No, there has not yet been discussion about removing this feature. I don't believe it was a successful addition though so opening this PR was my way to get the conversation started. I would certainly appreciate input for everyone who has an opinion. |
Contributor
|
This is not necessary anymore, as @scruffian fixed pattern saving with #790. I close this PR. It's also clear that pattern management has a place in this plugin. So if something is not working for you. A new issue would be the best place to start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the "Pattern Management" option from Create Block Theme.
Notes that patterns that are generated to support localization and local assets used in templates remain. (They are not "editable" however they are updated when changes to a template are made are re-exported. This is not new behavior.)
Exporting "synced" patterns as "unsynced" patterns is very confusing and breaks the workflow of creating patterns for a theme. Considering how confusing and damaging it is to themes being edited I propose a completely different mechanism for editing patterns. In the meantime this should probably be removed.