Skip to content

Correct the documented type for the $w parameter of block_core_navigation_add_directives_to_submenu() - #53585

Merged
aristath merged 1 commit into
trunkfrom
WP_HTML_Tag_Processor
Oct 9, 2023
Merged

Correct the documented type for the $w parameter of block_core_navigation_add_directives_to_submenu()#53585
aristath merged 1 commit into
trunkfrom
WP_HTML_Tag_Processor

Conversation

@johnbillion

@johnbillion johnbillion commented Aug 11, 2023

Copy link
Copy Markdown
Member

What?

This correct the docblock for block_core_navigation_add_directives_to_submenu() which incorrectly documents the $w parameter as a string.

@johnbillion johnbillion added the [Type] Developer Documentation Documentation for developers label Aug 11, 2023

@jorgefilipecosta jorgefilipecosta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aristath
aristath force-pushed the WP_HTML_Tag_Processor branch from b22f099 to 9e4a2be Compare October 9, 2023 11:02
@aristath

aristath commented Oct 9, 2023

Copy link
Copy Markdown
Member

@johnbillion This PR was stale and there was a conflict with trunk.
I rebased it, so once tests pass we'll be able to merge it 👍

@aristath
aristath enabled auto-merge (squash) October 9, 2023 11:03
@github-actions

github-actions Bot commented Oct 9, 2023

Copy link
Copy Markdown

Flaky tests detected in 9e4a2be.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6455731108
📝 Reported issues:

@aristath
aristath merged commit 5cf045d into trunk Oct 9, 2023
@aristath
aristath deleted the WP_HTML_Tag_Processor branch October 9, 2023 11:50
@github-actions github-actions Bot added this to the Gutenberg 16.9 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

3 participants