Edit Site: Rename CanvasSpinner to CanvasLoader - #53728
Merged
Merged
Conversation
tyxla
added
[Type] Code Quality
tyxla
requested review from
ajitbohra,
kevin940726,
nerrad and
ntwb
as code owners
August 16, 2023 11:11
5 tasks
|
Size Change: +304 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
rename/canvas-spinner-loader
branch
2 times, most recently
from
August 17, 2023 12:25
df45b85 to
c7c9834
Compare
|
Flaky tests detected in 6b309f0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5936558367
|
tyxla
force-pushed
the
rename/canvas-spinner-loader
branch
4 times, most recently
from
August 18, 2023 09:09
9735dae to
d2d50d0
Compare
tyxla
force-pushed
the
rename/canvas-spinner-loader
branch
from
August 18, 2023 11:32
d2d50d0 to
2d963cc
Compare
ntsekouras
approved these changes
Aug 21, 2023
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
Thank you for following up on this! I left a couple of small nits, but this is good to land.
| const SELECTORS = { | ||
| visualEditor: '.edit-site-visual-editor iframe', | ||
| loadingSpinner: '.edit-site-canvas-spinner', | ||
| loadingProgressBar: '.edit-site-canvas-loader', |
Contributor
There was a problem hiding this comment.
Nit: rename to canvasLoader.
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR renames the
CanvasSpinnercomponent toCanvasLoaderas recommended by @ntsekouras in #53032 (comment). It also makes a lot of sense, given that the component no longer displays a spinner, but a progress bar.Why?
This PR is a simple rename of a component to match the new functionality and UI.
How?
We're just renaming the directory and the component.
Testing Instructions
Verify the site editor still loads correctly and all checks are green.
Testing Instructions for Keyboard
None
Screenshots or screencast
None