i18n Make No color selected translatable text. - #54814
Merged
Merged
Conversation
apeatling
reviewed
Sep 27, 2023
Contributor
None that I recall, I'm pretty sure it was an oversight on my part - glad it got spotted and is being addressed! |
jorgefilipecosta
approved these changes
Oct 9, 2023
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
Member
There was a problem hiding this comment.
Thank you for catching this @shimotmk. The change worked well on a simple smoke test I did. I guess we can merge this PR.
justintadlock
added
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Make
No color selectedtranslatable text.Testing Instructions
Place the block that uses the color palette and open the color palette.
Screenshots or screencast