Conversation
richtabor
added
[Type] Enhancement
richtabor
marked this pull request as ready for review
October 4, 2023 17:00
|
Size Change: -102 B (0%) Total Size: 1.64 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 723c0e2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6409880910
|
ajlende
approved these changes
Oct 5, 2023
ajlende
left a comment
ajlende
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. 👍
I did a quick search and can confirm that this is the last place that the 16:10 ratio needed to be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #48041 and aligns all the aspect ratio options throughout blocks. Follow-up to #48969.
Why?
Consistency across the board; there's already an option for 16:9.
Testing Instructions
Screenshots or screencast
Other aspect ratio options (which will be further consolidated together):
