Fix wrong notification message shown when an entity is moved to trash - #55155
Merged
Conversation
|
Size Change: +9 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 9, 2023
Mamaduka
left a comment
Mamaduka
left a comment
Member
There was a problem hiding this comment.
Thanks, Nik!
It works well in my test ✅
|
Flaky tests detected in 76e8066. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6454671285
|
ntsekouras
enabled auto-merge (squash)
October 9, 2023 11:33
tyxla
approved these changes
Oct 9, 2023
tyxla
left a comment
tyxla
left a comment
Member
There was a problem hiding this comment.
Works well, thanks for the fix 🚀
Member
|
@ntsekouras, feel free to ignore failing Cover block test. It's flaky. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #19144
When moving a post to
trashfrom the Document settings panel, the notification message after successful completion of operation is that the post has been reverted to draft. This PR uses the new labels added in [6.3] (https://core.trac.wordpress.org/changeset/55923) and shows the proper message.Noting that in the redirect to the main list happens quite quickly and in order to view the snackbar, we need slow internet connection. You can use the devtools for that.
Testing Instructions