Data: Fix combineReducers() types - #55321
Merged
Merged
Conversation
tyxla
added
[Type] Bug
tyxla
requested review from
Mamaduka,
WunderBart,
flootr,
fullofcaffeine,
jsnajdr and
noahtallen
October 12, 2023 17:06
This was referenced Oct 12, 2023
|
Size Change: +2 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a9c4fe0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6498794631
|
noahtallen
approved these changes
Oct 12, 2023
noahtallen
left a comment
noahtallen
left a comment
Member
There was a problem hiding this comment.
I compared the build types on trunk vs this branch, and this definitely fixes the issue! Thanks :) I'll research how to release this to npm.
tyxla
enabled auto-merge (squash)
October 12, 2023 17:49
noahtallen
pushed a commit
that referenced
this pull request
Oct 12, 2023
Member
|
Am now following the process documented here: https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/release.md#standalone-bugfix-package-releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the built types of the
combineReducersutility that we export from@wordpress/data.Why?
In #54606 we broke the types of
combineReducersbecause the inline JSDoc type definition for thecombineReducersexport no longer worked with the newexport { module }syntax.This bug was reported in #54606 (comment)
How?
We're using the
export constsyntax and that resolves the inline JSDoc type so it properly picks it up as it did before.Testing Instructions
@wodpress/datapackage and verify that thecombineReducerstype properly uses the type definition from the package's types.Testing Instructions for Keyboard
None
Screenshots or screencast
None