[Data views]: Fix pagination - #55387
Merged
Merged
Conversation
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
jameskoster,
mcsf,
oandregal and
youknowriad
October 16, 2023 14:29
|
Size Change: +4 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d7372bf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6535994666
|
ntsekouras
force-pushed
the
fix/dataviews-pagination
branch
from
October 16, 2023 15:42
df1bdd6 to
d7372bf
Compare
ntsekouras
force-pushed
the
fix/dataviews-pagination
branch
from
October 17, 2023 08:46
d7372bf to
5ef072d
Compare
youknowriad
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of: #55095
This PR fixes some issues with pagination in data views.
Additionally since we are using the interface of the view config, there is no reason now to start the
pagefrom zero. We did that at first due to tanstack API.Testing Instructions
rows per pageor type something into the global text filter. Page should reset to the first one.