[Data views]: Rename accessorFn to getValue - #55434
Merged
Merged
Conversation
ntsekouras
added
[Type] Code Quality
|
Size Change: +28 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6a0247e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6557059055
|
oandregal
reviewed
Oct 18, 2023
| const { render, ...column } = field; | ||
| column.cell = ( props ) => render( props.row.original, view ); | ||
| const { render, getValue, ...column } = field; | ||
| column.cell = ( props ) => |
Member
There was a problem hiding this comment.
We should also cover against field.render not existing, e.g.: status.
Contributor
Author
There was a problem hiding this comment.
This happens in the parent component: https://github.com/WordPress/gutenberg/pull/55434/files#diff-a72d10c309e831c5e03caff0c1b9cfb82885abb105377a196cca642ea4d711adR32
Member
There was a problem hiding this comment.
ok, that's confusing 😅 Can we normalize both things in the same place?
Contributor
Author
There was a problem hiding this comment.
A follow-up we may need to do is the following: the tanstack API may use the presence of accessorFn and cell to determine whether a feature is enabled or not
Exactly that. Let's do that in a separate PR and see if we can remove the getValue completely.
oandregal
approved these changes
Oct 18, 2023
oandregal
left a comment
oandregal
left a comment
Member
There was a problem hiding this comment.
I left a comment I'd like us to address at https://github.com/WordPress/gutenberg/pull/55434/files#r1363355741 Other than that, it's ready.
A follow-up we may need to do is the following: the tanstack API may use the presence of accessorFn and cell to determine whether a feature is enabled or not. For example, accessorFn is used to determine whether a column is filterable. We'd need to review these tanstack details, so they don't leak into our own API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Small follow up of: #55411
Renames
accessorFntogetValueand updates the signature to of both to accept an object, so they can be used as components.Testing Instructions