DependencyExtractionWebpackPlugin: Drop webpack4 and node<18 - #57303
Merged
Conversation
Webpack 5 was released ~3 years ago. New features are being developed around ECMAScript modules, which are unsupported in webpack 4.
v18 is the current LTS release of Node. Older versions are not supported.
sirreal
added
[Type] Breaking Change
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
gziolo
reviewed
Dec 21, 2023
Member
|
The lock file needs a refresh: https://github.com/WordPress/gutenberg/actions/runs/7287680671/job/19858795322?pr=57303. Thank you so much for taking care of this legacy support for webpack 4. We don't need it anymore. I think we removed other webpack 4 specific plugin long time ago. |
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
sirreal
requested review from
ajitbohra,
nerrad,
ntwb and
ryanwelcher
as code owners
December 21, 2023 12:03
|
Flaky tests detected in 75d793b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7287855004
|
gziolo
approved these changes
Dec 21, 2023
gziolo
left a comment
gziolo
left a comment
Member
There was a problem hiding this comment.
Everything looks good from my perspective.
There are two CI failures on newly added options jobs running Node 21. It might be some caching related issue. Let me know if you can't make them pass and need help force merging this PR.
bph
added
the
Needs Dev Note
Contributor
|
The dev note doesn't have to be a full-blown post, it could be part of a collection of dev notes. It definitely would need to elaborate on the 'Breaking change'. |
Member
Author
|
Hi @bph. It may not be clear, but this isn't going to impact the WordPress experience in any way. The affected packages may be used by developers building for WordPress. The packages are consumed via npm. A dev note blurb (I agree a complete post is not necessary) would read something like the following:
|
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
32 tasks
sirreal
added
has dev note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Dependency Extraction Webpack Plugin:
Scripts:
(dropping from the webpack plugin implies dropping support from scripts)
Why?
Webpack 5 was released more that 3 years ago. Webpack 4 does not support modules, which blocks work on better module support and the modules API.
Node 18 is the oldest maintained Node.js release. Drop support for older versions.
Testing
CI tests should be sufficient for this change. I suggest reviewing changes without whitespace to see that very little code is changed.