Components: Remove deprecation warnings for __next36pxDefaultSize - #58703
Merged
Conversation
mirka
added
[Type] Code Quality
|
Size Change: -135 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
mirka
marked this pull request as ready for review
February 6, 2024 13:54
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
approved these changes
Feb 7, 2024
# Conflicts: # packages/components/src/input-control/input-base.tsx
mirka
enabled auto-merge (squash)
February 7, 2024 13:33
|
Flaky tests detected in 0cbbc0a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7815564569
|
32 tasks
mirka
added
has dev note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #46741
What?
Removes the console logging of deprecation warnings for the
__next36pxDefaultSizeprop.Why?
Based on consumer feedback in #55401.
Testing Instructions
See the Storybook for any of the affected components. Toggling the control for
__next36pxDefaultSizetotrueshould not log a deprecation warning in the console.✍️ Dev Note
A few releases ago, we introduced a
__next36pxDefaultSizeprop on several components, meant to coordiate the transition to a new default sizing scheme (36px height). Due to some changes in our design direction, we eventually dropped this prop in favor of the__next40pxDefaultSizeprop (40px height), making all existing opt-ins to the__next36pxDefaultSizeprop act as an opt-in to the 40px one.After receiving developer feedback about this ahead of WordPress 6.5, we will no longer throw a deprecation warning for usages of the
__next36pxDefaultSizeprop informing consumers of this change. Do note however that it will trigger the new 40px size rather than the 36px size, despite the prop name.