Patterns: Change the icon and label for pattern section to use the pattern icon and name - #73203
Merged
Conversation
scruffian
added
[Type] Enhancement
|
Size Change: +130 B (+0.01%) Total Size: 2.49 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 49a95a5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19299574308
|
ramonjd
reviewed
Nov 13, 2025
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
I like the direction, thanks for getting it up! I tested with theme and user patterns. There were no errors when I deleted a pattern in the site admin and refresh the page.
| Before | After |
|---|---|
 |
 |
How do you think we should handle blocks with "templateLock":"contentOnly" and template parts? The icons in the list view/tool bar/inspector don't match.
| templateLock | Header |
|---|---|
 |
 |
Also, not for this PR but a general question: when two blocks are selected we show "n blocks" in the sidebar. Not a biggie really.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
force-pushed
the
update/pattern-details
branch
from
November 14, 2025 12:11
49a95a5 to
bb25d87
Compare
Contributor
Author
Good point. I removed the icons from template parts and contentOnly locked blocks. |
ramonjd
force-pushed
the
update/pattern-details
branch
from
November 17, 2025 23:16
296cde4 to
b7cded8
Compare
ramonjd
approved these changes
Nov 17, 2025
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
Thanks for the changes. LGTM
Here's what I'm seeing:
Kapture.2025-11-18.at.10.16.22.mp4
And in trunk (patterns show icons of their root blocks)
Contributor
|
Nice one, I think this follows @fcoveram's instinct too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Changes the block icon, name and description to be pattern icons/description, for patterns that are sections.
From #72574
Why?
This helps to consolidate the behaviour were adding to section blocks, by updating the UI to treat patterns as blocks in their own right.
How?
Add exceptions for section blocks
Testing Instructions
Screenshots or screencast