DataViews: ensure primary actions are not wrapped in the list layout - #73333
Merged
Conversation
t-hamano
added
Backport to WP 6.9 Beta/RC
[Feature] DataViews
|
Size Change: +4 B (0%) Total Size: 2.49 MB
ℹ️ View Unchanged
|
t-hamano
marked this pull request as ready for review
November 17, 2025 02:22
t-hamano
requested review from
gigitux,
ntsekouras and
oandregal
as code owners
November 17, 2025 02:22
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
approved these changes
Nov 17, 2025
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! I also tested with longer texts in the primary action in english and looks way better than trunk.
Contributor
Author
|
@ntsekouras Thanks for the review! |
|
There was a conflict while trying to cherry-pick the commit to the wp/6.9 branch. Please resolve the conflict manually and create a PR to the wp/6.9 branch. PRs to wp/6.9 are similar to PRs to trunk, but you should base your PR on the wp/6.9 branch instead of trunk. |
Contributor
Author
This is common and is due to a conflict in the CHANGELOG file of the dataviews package, so I'd like to manually create a PR for the backport. |
t-hamano
added a commit
that referenced
this pull request
Nov 17, 2025
…73333) * Don't wrap primary button text in list layout * Add changelog Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Contributor
Author
t-hamano
added
Backported to WP Core
shekharnwagh
pushed a commit
to Automattic/gutenberg
that referenced
this pull request
Jan 14, 2026
…ordPress#73333) (WordPress#73345) * Don't wrap primary button text in list layout * Add changelog Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: priethor <priethor@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I found that the primary action button text is unexpectedly wrapped in some locales.
ja)zh_CN)Why? How?
As with the table layout,
white-space: nowrapis required.Testing Instructions
日本語.