FontFamilyControl: Hard deprecate bottom margin - #73340
Merged
Merged
Conversation
t-hamano
added
[Type] Enhancement
t-hamano
marked this pull request as ready for review
November 17, 2025 08:50
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
21 tasks
|
Size Change: -145 B (-0.01%) Total Size: 2.51 MB
ℹ️ View Unchanged
|
mirka
approved these changes
Nov 18, 2025
mirka
left a comment
mirka
left a comment
Member
There was a problem hiding this comment.
Thanks for the cleanup! I also found one usage we can remove:
Contributor
Author
Good catch! Fixed in 306c9cc |
ramonjd
pushed a commit
that referenced
this pull request
Nov 19, 2025
* FontFamilyControl: Hard deprecate bottom margin * Remove unnecessary __nextHasNoMarginBottom prop Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #39358
What?
Hard deprecate the
__nextHasMarginBottomprop from the hoge component.Why?
See #39358
Testing Instructions
Storybook
Gutenberg
In the Gutenberg project, this component is used exclusively in typography. There should be no visual changes.