Build: moment-timezone shouldn't be a mandatory dependency - #73352
Merged
Conversation
youknowriad
added
the
[Type] Build Tooling
Contributor
|
Thanks for the fix. Now I can build the project without adding the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…d styles (#73355) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: Utsav-Ladani <utsavladani@git.wordpress.org>
youknowriad
enabled auto-merge (squash)
November 17, 2025 13:38
|
Size Change: 0 B Total Size: 2.49 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #72032
What?
Fix
momentTimezoneAliasPluginin@wordpress/buildto use lazy resolution, preventing crashes when building plugins that don't havemoment-timezonein their dependency tree.Why?
The plugin was calling
require.resolve()unconditionally during setup, causing builds to fail for plugins using@wordpress/buildwithout@wordpress/date.How?
Move path resolution into the
onResolvecallbacks with caching, so paths are only resolved when moment-timezone imports are actually encountered.