Unit testing: Allow Composer to auto-detect PHP version by priethor · Pull Request #73358 · WordPress/gutenberg

priethor · 2025-11-17T13:45:46Z

What?

Fixes composer settings and unit test workflow so that Composer can auto-detect the right PHP executing the Unit Test job matrix.

Why?

It caused dependency resolution failures and broke unit tests for PHP 7.2 versions.

How?

Removing the platform.php setting
Setting the require.php setting to >=7.2.24, the current minimum PHP version supported by WordPress
Removing the composer override step from the unit tests workflow

priethor · 2025-11-17T15:26:51Z

                    # On PRs: Only test PHP 8.3, single-site, latest WP
-                    - event: 'pull_request'
-                      php: '7.2'
+                    # TEMP: PHP 7.2 enabled for testing the Composer fix - do not merge


Note that this needs to be undone before merging; it's only there to trigger the PHP 7.2 tests in this PR.

Excluded it again since PHP 7.2 tests pass in this PR

I actually feel that this change should be reverted. But that's a discussion for another ticket.

Can you say more about that, so that we spin a follow-up PR?

github-actions · 2025-11-17T15:31:39Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: priethor <priethor@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: aduth <aduth@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

desrosj · 2025-11-17T15:33:38Z

-		"platform": {
-			"php": "7.4"
-		},


Instead of removing this entirely, let's change it to `"php": ">=7.2.24"

Are version ranges supported in this context? 🤔

I'm wondering if this should be specified under require.php, not config.platform.

Ref: https://getcomposer.org/doc/articles/composer-platform-dependencies.md

Platform doesn't accept >=, only specific versions.

@aduth I agree require.php is a better setting for this purpose. What do you think, @desrosj ?

@priethor That works for me!

Done in 0fe9d04, with composer validate running successfully

The PHP 7.2 Unit Tests job successfully passes with the require.php setting.

…rsion required.

aduth

LGTM

priethor · 2025-11-18T20:57:07Z

@desrosj I'm going ahead and merging this to get the tests fixed on trunk, since we were all on the same page about the blocker issue, and it's already addressed.

Let me know if there is any other adjustment needed from your perspective, and I'll gladly follow up 🙏

The feedback was addressed as agreed.

Co-authored-by: priethor <priethor@git.wordpress.org> Co-authored-by: desrosj <desrosj@git.wordpress.org> Co-authored-by: aduth <aduth@git.wordpress.org> Co-authored-by: swisspidy <swisspidy@git.wordpress.org>

priethor · 2025-11-19T19:50:55Z

Cherry-picked to wp/6.9 branch in d2eb077 to ensure PHPUnit tests pass there.

Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/. * [Fix isNewLink value with entity binding (#73368)](WordPress/gutenberg#73368) * [Unit testing: Allow Composer to auto-detect PHP version (#73358)](WordPress/gutenberg#73358) * [Move the Edit Navigation button to the last item in the block toolbar to ensure that the styling is consistent and simple (#73436)](WordPress/gutenberg#73436) * [Block Support: Change block visibility support key (#73432)](WordPress/gutenberg#73432) * [Accordion: add box-sizing:border-box rule (#73507)](WordPress/gutenberg#73507) * [Accordion Block: Trigger panel opening from URL hash or anchor link (#73357)](WordPress/gutenberg#73357) * [iAPI: Backport of "Return a deep-clone object from `getServerState` and `getServerContext` functions" (#73514)](WordPress/gutenberg#73514) * [Reuse wp_script_attributes filter for adding data-wp-router-options attribute to script module (#72489) (#73512)](WordPress/gutenberg#73512) * [Accordion Item: Don't use grid layout (#73501)](WordPress/gutenberg#73501) * [Drag and drop: remove grab cursor for multi-selection (#73521)](WordPress/gutenberg#73521) * [Math block: fix accessibility (#73508)](WordPress/gutenberg#73508) * [iAPI: Fix using `getServerContext` in derived state getters (#73518) (#73531)](WordPress/gutenberg#73531) * [Drag: hide block tools popovers (#73539)](WordPress/gutenberg#73539) Developed in #10549. See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches. Props priethor. See #64301. git-svn-id: https://develop.svn.wordpress.org/branches/6.9@61304 602fd350-edb4-49c9-b593-d223f7449a82

Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/. * [Fix isNewLink value with entity binding (#73368)](WordPress/gutenberg#73368) * [Unit testing: Allow Composer to auto-detect PHP version (#73358)](WordPress/gutenberg#73358) * [Move the Edit Navigation button to the last item in the block toolbar to ensure that the styling is consistent and simple (#73436)](WordPress/gutenberg#73436) * [Block Support: Change block visibility support key (#73432)](WordPress/gutenberg#73432) * [Accordion: add box-sizing:border-box rule (#73507)](WordPress/gutenberg#73507) * [Accordion Block: Trigger panel opening from URL hash or anchor link (#73357)](WordPress/gutenberg#73357) * [iAPI: Backport of "Return a deep-clone object from `getServerState` and `getServerContext` functions" (#73514)](WordPress/gutenberg#73514) * [Reuse wp_script_attributes filter for adding data-wp-router-options attribute to script module (#72489) (#73512)](WordPress/gutenberg#73512) * [Accordion Item: Don't use grid layout (#73501)](WordPress/gutenberg#73501) * [Drag and drop: remove grab cursor for multi-selection (#73521)](WordPress/gutenberg#73521) * [Math block: fix accessibility (#73508)](WordPress/gutenberg#73508) * [iAPI: Fix using `getServerContext` in derived state getters (#73518) (#73531)](WordPress/gutenberg#73531) * [Drag: hide block tools popovers (#73539)](WordPress/gutenberg#73539) Developed in WordPress/wordpress-develop#10549. See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches. Props priethor. See #64301. Built from https://develop.svn.wordpress.org/branches/6.9@61304 git-svn-id: http://core.svn.wordpress.org/branches/6.9@60616 1a063a9b-81f0-0310-95a4-ce76da25c4cd

priethor added 4 commits November 17, 2025 14:42

Pin PHP 7.2 to 7.2.24 to satisfy dependencies

c1591f8

Temporarily enable PHP 7.2 Unit Tets for the PR

64fdcbe

Undo pinning the version in the GH workflow

dd81f57

Fix PHP platform in composer settings

8d4b14b

priethor force-pushed the fix/php-72-unit-tests branch from 2131388 to 8d4b14b Compare November 17, 2025 13:59

priethor added 2 commits November 17, 2025 15:04

Remove the platform entirely

c0f77c8

Remove composer override step in unit test workflow

cce6e96

priethor changed the title ~~Unit testing: Pin PHP 7.2 to 7.2.24 to satisfy dependencies~~ Nov 17, 2025

priethor commented Nov 17, 2025

View reviewed changes

priethor self-assigned this Nov 17, 2025

priethor added the GitHub Actions Pull requests that update GitHub Actions code label Nov 17, 2025

priethor marked this pull request as ready for review November 17, 2025 15:27

priethor requested a review from desrosj as a code owner November 17, 2025 15:27

priethor added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Nov 17, 2025

priethor requested review from aduth, swissspidy and youknowriad November 17, 2025 15:28

Exclude again 7.2 tests in PRs

780bd86

desrosj previously requested changes Nov 17, 2025

View reviewed changes

Add composer.php settings with the actual minimum version supported

5d5922e

priethor force-pushed the fix/php-72-unit-tests branch from 5f9946f to 5d5922e Compare November 17, 2025 15:41

priethor added 3 commits November 17, 2025 16:45

Add again 7.2 tests to workflow for testing

89ee942

Use require.php setting instead of platform to set the minimum ve…

0fe9d04

…rsion required.

Exclude back PHP7.2 unit tests in PRs

4195d90

aduth requested a review from desrosj November 18, 2025 12:59

aduth approved these changes Nov 18, 2025

View reviewed changes

priethor enabled auto-merge (squash) November 18, 2025 13:10

priethor added the Backport to WP 6.9 Beta/RC label Nov 18, 2025

priethor merged commit 5aea6b2 into trunk Nov 18, 2025
40 of 41 checks passed

priethor deleted the fix/php-72-unit-tests branch November 18, 2025 20:57

github-actions Bot added this to the Gutenberg 22.2 milestone Nov 18, 2025

priethor removed the Backport to WP 6.9 Beta/RC label Nov 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Unit testing: Allow Composer to auto-detect PHP version - #73358

Unit testing: Allow Composer to auto-detect PHP version#73358
priethor merged 11 commits into
trunkfrom
fix/php-72-unit-tests

priethor commented Nov 17, 2025 •

edited

Loading

priethor Nov 17, 2025

priethor Nov 17, 2025

desrosj Nov 17, 2025

priethor Nov 17, 2025

github-actions Bot commented Nov 17, 2025 •

edited

Loading

desrosj Nov 17, 2025

aduth Nov 17, 2025

aduth Nov 17, 2025 •

edited

Loading

priethor Nov 17, 2025 •

edited

Loading

priethor Nov 17, 2025

desrosj Nov 17, 2025

priethor Nov 17, 2025

priethor Nov 17, 2025

aduth left a comment

priethor commented Nov 18, 2025

Uh oh!

priethor commented Nov 19, 2025

Labels

3 participants

Uh oh!

Conversation

priethor commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

How?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions Bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aduth Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

priethor Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aduth left a comment

Choose a reason for hiding this comment

priethor commented Nov 18, 2025

Uh oh!

priethor commented Nov 19, 2025

Labels

3 participants

priethor commented Nov 17, 2025 •

edited

Loading

github-actions Bot commented Nov 17, 2025 •

edited

Loading

aduth Nov 17, 2025 •

edited

Loading

priethor Nov 17, 2025 •

edited

Loading