Skip to content

Storybook: Replace implicit actions with explicit ones - #73502

Merged
t-hamano merged 3 commits into
trunkfrom
try/explicit-action-declaration-storybook-alt
Nov 23, 2025
Merged

Storybook: Replace implicit actions with explicit ones#73502
t-hamano merged 3 commits into
trunkfrom
try/explicit-action-declaration-storybook-alt

Conversation

@t-hamano

@t-hamano t-hamano commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

Closes #60660

This PR is equivalent to #70589 and resolves the code conflict. Additionally, I made changes according to this comment.

What?

Replaces implicit action args (matched via argTypesRegex) with explicit fn() spies from @storybook/test in stories. Some components had there stories updated in this PR

Why? How? Testing Instructions

See #70589

@t-hamano t-hamano self-assigned this Nov 23, 2025
@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality Storybook Storybook and its stories for components labels Nov 23, 2025
@t-hamano
t-hamano marked this pull request as ready for review November 23, 2025 09:38
@github-actions

github-actions Bot commented Nov 23, 2025

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these components in story book.

Here's one:
Screenshot 2025-11-23 at 9 35 06 pm

They work fine :)

@t-hamano

Copy link
Copy Markdown
Contributor Author

@ramonjd Thanks for the review!

@t-hamano
t-hamano merged commit 4b0cc98 into trunk Nov 23, 2025
45 checks passed
@t-hamano
t-hamano deleted the try/explicit-action-declaration-storybook-alt branch November 23, 2025 13:20
@github-actions github-actions Bot added this to the Gutenberg 22.2 milestone Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storybook Storybook and its stories for components [Type] Code Quality Issues or PRs that relate to code quality

3 participants