Components: remove "text-wrap: balance" fallback from Text #75089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simison
added
[Type] Enhancement
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
simison
commented
Jan 30, 2026
|
|
||
| ## Unreleased | ||
|
|
||
| ### Breaking Changes |
Member
Author
There was a problem hiding this comment.
Should this be considered breaking change? 🤔
Contributor
There was a problem hiding this comment.
To me, this change seems like a bug fix.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -6 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Jan 30, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I think this change makes sense to me. Pinging @WordPress/gutenberg-components for visibility
Contributor
|
@simison Can you run the following command to update the snapshots? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Spin off from #74907
Removes the
text-wrap: balancefallback from theTextcomponent. The component now uses onlytext-wrap: prettywithout theSafariFirefox fallback.The code says it was Safari fallback, but actually it's Firefox which doesn't support
pretty:Why?
During discussion in PR #74907 about removing
text-wrap: balancefallbacks, it was noted that theTextcomponent also includes this fallback pattern. Thetext-wrap: balancefallback was originally added for Safari compatibility.balancecreates visually more opinionated layout compared topretty, which pretty much only handles typographic orphans. Balance is causing issues with non-Latin languages like Japanese:text-wrap: balance)text-wrap: balance)How?
The
Textcomponent now only includestext-wrap: pretty.Testing Instructions
Text(like labels, descriptions, etc.) still renders correctly without any visual regressions. You can browse Site editor pages to see it in action.Testing Instructions for Keyboard
None.
Screenshots or screencast
None.