Stretchy Text: Fix focus loss #75092
Open
+74
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Focus] Accessibility (a11y)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -72 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes focus loss when changing settings by adjusting how
FitTextControlis mounted.Before
before.mp4
After
after.mp4
Why?
In the current implementation, a different
FitTextControlcomponent is mounted depending on whether thefitTextattribute is enabled or not. TheFitTextControlcontains aToolsPanelItemcomponent, so when the state of the toggle is changed, theFitTextControlcomponent is remounted and loses focus. Furthermore, when the toggle is turned off, the toggle itself disappears.How?
Completely decouple the toggle UI from the hook and warning component. The hook will only run if
fitTextis enabled as before.Testing Instructions