iAPI Router: Update cached styles for re-fetched pages #75097
+94
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Draft
13 tasks
|
Size Change: -24 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the Interactivity API Router not updating styles when a cached page is re-fetched with
force: true.Why?
When
navigate( url, { force: true } )is called, thepagescache is correctly bypassed, and a fresh HTML fetch is triggered. However, the internalpreloadStyles()function maintained its ownstyleSheetCache, keyed by URL, which was never invalidated. The freshly fetched DOM's styles were completely ignored, and stale cached style references were returned instead.This meant that force-navigating to a previously visited page would not load any new styles, even if the HTML response included new blocks or new stylesheets. The page regions would update with the new content, but the corresponding styles would be missing.
How?
The PR removes
styleSheetCachefrompreloadStyles()entirely. This cache level is redundant, as pages are already cached with their corresponding Style elements. ThepreloadStyles()function would only be called for the same URL if that URL is being re-fetched withforce: true, in which case styles always need to be recomputed.Testing Instructions
@wordpress/interactivity-routermodule available in the console.@wordpress/interactivity-routermodule in the console.