Components Style: Clean up admin-scheme usage #75098
Conversation
SirLouen
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @use "./validated-form-controls/style.scss" as *; | ||
|
|
||
| // Include the default WP Components color variables. | ||
| // TODO: Remove this once all admin-scheme variables are accounted for in the wp-components fallback values. |
There was a problem hiding this comment.
This comment seems to imply that we don't actually want this admin-scheme to be applied, that it should be achieved through fallback values in component styles. I feel like we're no longer setting an expectation of that goal with this refactor.
There was a problem hiding this comment.
By adding default colors I'm assuming that as this new pattern grows expectations will be fulfilled by convenience, dont you think so?
Do you think that this still is going to hold any value for the future?
2 participants
Why?
Minor fix, during chore code analysis in the works of #75096 I noted that this was being duplicated unnecessarily,
How?
Simply importing the default styles and removing duplication.