-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Theme: Update elevation tokens to use abbreviated size names #75103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| - `--wpds-border-width-surface-md`: use `--wpds-border-width-md` instead. | ||
| - `--wpds-border-width-surface-lg`: use `--wpds-border-width-lg` instead. | ||
| - `--wpds-border-width-interactive-focus`: use `--wpds-border-width-focus` instead. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing formatting is pretty messed up:
The extra newline here is strange, but I use Prettier format-on-save, and it insists on it for some reason. My friend Claude seems to think it's something to do with how long the preceding line is.
|
Size Change: -49 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
What?
Updates elevation tokens to use the abbreviated size name conventions we're using in other token groups.
Why?
Consistency.
While we may still want to do an audit of these token values, the least we can do is be consistent with common naming like "x-small" vs. "xs".
Testing Instructions
npm run --workspace=@wordpress/theme build