Start the catalog service as part of ov just init - #5300
Conversation
obulat
left a comment
There was a problem hiding this comment.
Nice, thank you, @AetherUnbound !
dhruvkb
left a comment
There was a problem hiding this comment.
Late to the review, but it'd be nice to take down the additional services after the init step so that they're not taking up system resources when the user is concerned with the API.
That's fair, but the best way to accomplish this (I think) would be taking down the whole stack, then just spinning the API back up again. Otherwise we'd have to explicitly list the services to shut down in the |
Fixes
This fixes an issue I identified while trying to run
ov just init- see the Make WordPress SlackDescription
This PR modifies the
ov just initscript to start the catalog stack at the very beginning, so that it's ready and initialized for thejust catalog/clicommands that come later in theload_sample_data.shscript.Testing Instructions
On
mainRun
ov just initand observe that it fails:On this branch
ov just initshould run successfully without interventionChecklist
Update index.md).main) or a parent feature branch.ov just catalog/generate-docsfor catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-propsfor the catalog or
ov just api/generate-docsfor the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin